OpenZeppelin UUPS Proxy Initialization Vulnerability - Revision history

Azoundria at 01:30, 4 May 2023

2023-05-04T01:30:03Z

← Older revision		Revision as of 19:30, 3 May 2023
Line 4:		Line 4:
	[[File:Openzeppelin.jpg\|thumb\|OpenZeppelin]]The OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts, thereby freezing funds.		[[File:Openzeppelin.jpg\|thumb\|OpenZeppelin]]The OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts, thereby freezing funds.

	This is a global/international case not involving a specific country.		This is a global/international case not involving a specific country.<ref name="openblocksecgithub-2342" /><ref name="openzeppelin-3733" /><ref name="openzeppelinforum-4119" /><ref name="openzeppelingithub-4120" /><ref name="openzeppelinforum-4121" /><ref name="geeksgmedium-4122" /><ref name="iosiro-4123" /><ref name="yehjxraymondgithub-4124" />
	<ref name="openblocksecgithub-2342" /><ref name="openzeppelin-3733" /><ref name="openzeppelinforum-4119" /><ref name="openzeppelingithub-4120" /><ref name="openzeppelinforum-4121" /><ref name="geeksgmedium-4122" /><ref name="iosiro-4123" /><ref name="yehjxraymondgithub-4124" />

	== About OpenZeppelin ==		== About OpenZeppelin ==
Line 73:		Line 72:
	!Description		!Description
	\|-		\|-
	\|September 9th, 2021 ~~12:00:00 AM~~		\|September 9th, 2021
	\|Main Event		\|Main Event
	\|Expand this into a brief description of what happened and the impact. If multiple lines are necessary, add them here.		\|Expand this into a brief description of what happened and the impact. If multiple lines are necessary, add them here.
Line 81:		Line 80:
	\|		\|
	\|}		\|}

			== Technical Details ==
			This section includes specific detailed technical analysis of any security breaches which happened. What specific software vulnerabilities contributed to the problem and how were they exploited?

	== Total Amount Lost ==		== Total Amount Lost ==
Line 100:		Line 102:
	== Ongoing Developments ==		== Ongoing Developments ==
	What parts of this case are still remaining to be concluded?		What parts of this case are still remaining to be concluded?
			== Individual Prevention Policies ==
			{{Prevention:Individuals:Placeholder}}

			{{Prevention:Individuals:End}}

			== Platform Prevention Policies ==
			{{Prevention:Platforms:Placeholder}}

			{{Prevention:Platforms:End}}

			== Regulatory Prevention Policies ==
			{{Prevention:Regulators:Placeholder}}

	== Prevention ~~Policies ==~~		{{Prevention:Regulators:End}}
	~~Which policies could have prevented this event from happening?~~

	== References ==		== References ==

Azoundria at 23:52, 27 February 2023

2023-02-27T23:52:03Z

Azoundria: Created page with "{{Imported Case Study|source=https://www.quadrigainitiative.com/casestudy/openzeppelinuupsproxyinitializationvulnerability.php}} OpenZeppelinThe OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts,..."

2023-01-27T21:24:58Z

Created page with "{{Imported Case Study|source=https://www.quadrigainitiative.com/casestudy/openzeppelinuupsproxyinitializationvulnerability.php}} thumb|OpenZeppelinThe OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts,..."

New page

{{Imported Case Study|source=https://www.quadrigainitiative.com/casestudy/openzeppelinuupsproxyinitializationvulnerability.php}}

[[File:Openzeppelin.jpg|thumb|OpenZeppelin]]The OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts, thereby freezing funds.

This is a global/international case not involving a specific country.

== About OpenZeppelin ==
"The standard for secure blockchain applications. OpenZeppelin provides security products to build, automate, and operate decentralized applications. We also protect leading organizations by performing security audits on their systems and products."

"OpenZeppelin Contracts includes several proxy contracts 7 for enabling upgradeability. All are based on the same concept: each upgradeable deployment consists of an implementation contract, which holds the code to be executed, and a proxy contract, which holds the state. Whenever a user calls the proxy contract, the proxy delegates execution to the implementation contract. In order to upgrade the contract, the proxy is pointed to a different implementation contract, thus changing the code being executed but preserving the same address and state. You can read more about how this pattern works here 11."

"The two most popular patterns in the library are the Transparent proxy and the UUPS proxy. As described here 6, the main difference between them is where the upgrade logic resides. In the Transparent proxy, the upgrade logic is in the proxy. In the UUPS pattern, the proxy delegates all calls to the implementation, which handles both the business logic and upgrade logic. This allows users to decide the authorization logic used for upgrades, such as Ownable 3 or AccessControl 2, or any other custom solution. To facilitate this, the library provides a base UUPSUpgradeable 12 contract that implementation contracts should extend from."

"The internal upgrade logic in UUPSUpgradeable performs several tasks. Besides changing the implementation contract stored in the proxy, it also executes a DELEGATECALL to the new implementation to atomically execute any migration function, as part of an upgradeToAndCall 9 action."

"In early September, we received two independent reports of a vulnerability in the UUPSUpgradeable base contract of the OpenZeppelin Contracts library, first released 9 in version 4.0 in April, 2021." "Upgradeable contracts using UUPSUpgradeable may be vulnerable to an attack affecting uninitialized implementation contracts." "Thank you Raymond Yeh 8 of Bluejay Finance 7 for disclosing this vulnerability 6 to us, including a working proof-of-concept of the exploit 20, on September 3rd."

"The vulnerability lies in the DELEGATECALL instructions in the upgrade function, exposed by the UUPSUpgradeable base contract. As described here 29, a DELEGATECALL can be exploited by an attacker by having the implementation contract call into another contract that SELFDESTRUCTs itself, causing the caller to be destroyed."

"Given an UUPS implementation contract, an attacker can initialize it 26 and appoint themselves as upgrade administrators. This allows them to call the upgradeToAndCall 9 function on the implementation directly, instead of on the proxy, and use it to DELEGATECALL into a malicious contract with a SELFDESTRUCT operation."

"If the attack is successful, any proxy contracts backed by this implementation become unusable, as any calls to them are delegated to an address with no executable code. Furthermore, since the upgrade logic resided in the implementation and not the proxy, it is not possible to upgrade the proxy to a valid implementation. This effectively bricks the contract, and impedes access to any assets held on it."

"On Sep 10, one week after initial contact, the team managed to setup a script to run a fix for 170 contracts across different chains and announce the initial fix on Twitter (for projects they might have missed)"

"Update September 14th: We have published a security advisory 9 and released Contracts v4.3.2 19 with a hotfix for this vulnerability."

"The mitigation for this vulnerability is simple: initializing the implementation contract. If the implementation is initialized, an attacker can no longer pass the authorization check of calling upgradeToAndCall in it. We shared this 14 on September 9th as a public security advisory before disclosing the fix and vulnerability, to minimize its impact." "Do not leave an implementation contract uninitialized. An uninitialized implementation contract can be taken over by an attacker, which may impact the proxy."

"Due to a vulnerability in OpenZeppelin Contracts v4.1.0 through v4.3.1 9, all projects using the UUPS proxy pattern should initialize their implementation contracts." "A transaction must be sent to the implementation contract (not the proxy) to invoke the initialize method. You can find out the address of the implementation contract given a proxy in Etherscan (if your contract source code is verified) on the “Read as Proxy” tab of the “Contract” section." "To help mitigate this situation, we have already executed transactions to initialize over 150 implementation contracts from multiple projects we identified across Mainnet, Polygon, xDAI, Binance, and Avalanche."

"Our team will thoroughly review the rollback test mechanism for the next release of the library. While the code provides solid guarantees against accidentally bricking the contract, it also requires the usage of the potentially dangerous DELEGATECALL operation. We will evaluate removing this check in favor of a simpler one, and adding more safeguards on the tooling side 6."

"In terms of processes, we plan to increase the number of required reviews for all major features in Contracts, especially when it involves a code change that requires going against a security recommendation, as is the case here."

"Last but not least, we are working on setting up active monitoring infrastructure to alert in the event of a deployment of a vulnerable uninitialized implementation contract. We will be sharing more news about this soon."

This is a global/international case not involving a specific country.

The background of the exchange platform, service, or individuals involved, as it would have been seen or understood at the time of the events.

Include:

* Known history of when and how the service was started.
* What problems does the company or service claim to solve?
* What marketing materials were used by the firm or business?
* Audits performed, and excerpts that may have been included.
* Business registration documents shown (fake or legitimate).
* How were people recruited to participate?
* Public warnings and announcements prior to the event.

Don't Include:
* Any wording which directly states or implies that the business is/was illegitimate, or that a vulnerability existed.
* Anything that wasn't reasonably knowable at the time of the event.
There could be more than one section here. If the same platform is involved with multiple incidents, then it can be linked to a main article page.

== The Reality ==
This sections is included if a case involved deception or information that was unknown at the time. Examples include:

* When the service was actually started (if different than the "official story").
* Who actually ran a service and their own personal history.
* How the service was structured behind the scenes. (For example, there was no "trading bot".)
* Details of what audits reported and how vulnerabilities were missed during auditing.

== What Happened ==
The specific events of the loss and how it came about. What actually happened to cause the loss and some of the events leading up to it.
{| class="wikitable"
|+Key Event Timeline - OpenZeppelin UUPS Proxy Initialization Vulnerability
!Date
!Event
!Description
|-
|September 9th, 2021 12:00:00 AM
|Main Event
|Expand this into a brief description of what happened and the impact. If multiple lines are necessary, add them here.
|-
|
|
|
|}

== Total Amount Lost ==
No funds were lost.

How much was lost and how was it calculated? If there are conflicting reports, which are accurate and where does the discrepancy lie?

== Immediate Reactions ==
How did the various parties involved (firm, platform, management, and/or affected individual(s)) deal with the events? Were services shut down? Were announcements made? Were groups formed?

== Ultimate Outcome ==
What was the end result? Was any investigation done? Were any individuals prosecuted? Was there a lawsuit? Was any tracing done?

== Total Amount Recovered ==
There do not appear to have been any funds recovered in this case.

What funds were recovered? What funds were reimbursed for those affected users?

== Ongoing Developments ==
What parts of this case are still remaining to be concluded?

== Prevention Policies ==
Which policies could have prevented this event from happening?

== References ==
[https://github.com/openblocksec/blocksec-incidents/blob/main/defi/2021.md blocksec-incidents/2021.md at main · openblocksec/blocksec-incidents · GitHub] (Aug 10)

[https://openzeppelin.com/ OpenZeppelin] (Oct 13)

[https://forum.openzeppelin.com/t/security-advisory-initialize-uups-implementation-contracts/15301 Security advisory: Initialize UUPS implementation contracts - Announcements - OpenZeppelin Community] (Dec 3)

[https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-5vp3-v4hc-gx76 UUPSUpgradeable vulnerability in OpenZeppelin Contracts · Advisory · OpenZeppelin/openzeppelin-contracts · GitHub] (Dec 3)

[https://forum.openzeppelin.com/t/uupsupgradeable-vulnerability-post-mortem/15680 UUPSUpgradeable Vulnerability Post-mortem - Announcements - OpenZeppelin Community] (Dec 3)

[https://geeksg.medium.com/my-journey-to-disclosing-a-vulnerability-that-can-lock-up-millions-in-ethereum-dcb5754ad9bc My Journey To Disclosing A Vulnerability That Can Lock Up Millions In Ethereum] (Dec 3)

[https://www.iosiro.com/blog/openzeppelin-uups-proxy-vulnerability-disclosure Perma-brick UUPS proxies with this one trick (devs hate this!) | iosiro] (Dec 3)

[https://github.com/yehjxraymond/exploding-kitten GitHub - yehjxraymond/exploding-kitten] (Dec 3)

← Older revision		Revision as of 17:52, 27 February 2023
Line 1:		Line 1:
	{{Imported Case Study\|source=https://www.quadrigainitiative.com/casestudy/openzeppelinuupsproxyinitializationvulnerability.php}}		{{Imported Case Study\|source=https://www.quadrigainitiative.com/casestudy/openzeppelinuupsproxyinitializationvulnerability.php}}
			{{Unattributed Sources}}

	[[File:Openzeppelin.jpg\|thumb\|OpenZeppelin]]The OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts, thereby freezing funds.		[[File:Openzeppelin.jpg\|thumb\|OpenZeppelin]]The OpenZeppelin smart contract framework had a vulnerability which would allow an adversary to take over the smart contract, if it hadn't been initialized yet. It's unclear if it was possible to take any funds using this method, however it was certainly possible to destroy existing smart contracts, thereby freezing funds.

	This is a global/international case not involving a specific country.		This is a global/international case not involving a specific country.
			<ref name="openblocksecgithub-2342" /><ref name="openzeppelin-3733" /><ref name="openzeppelinforum-4119" /><ref name="openzeppelingithub-4120" /><ref name="openzeppelinforum-4121" /><ref name="geeksgmedium-4122" /><ref name="iosiro-4123" /><ref name="yehjxraymondgithub-4124" />

	== About OpenZeppelin ==		== About OpenZeppelin ==
Line 103:		Line 105:

	== References ==		== References ==
	[https://github.com/openblocksec/blocksec-incidents/blob/main/defi/2021.md blocksec-incidents/2021.md at main · openblocksec/blocksec-incidents · GitHub] (Aug 10)		<references><ref name="openblocksecgithub-2342">[https://github.com/openblocksec/blocksec-incidents/blob/main/defi/2021.md blocksec-incidents/2021.md at main · openblocksec/blocksec-incidents · GitHub] (Aug 11, 2021)</ref>

	[https://openzeppelin.com/ OpenZeppelin] (Oct 13)		<ref name="openzeppelin-3733">[https://openzeppelin.com/ OpenZeppelin] (Oct 14, 2021)</ref>

	[https://forum.openzeppelin.com/t/security-advisory-initialize-uups-implementation-contracts/15301 Security advisory: Initialize UUPS implementation contracts - Announcements - OpenZeppelin Community] (Dec 3)		<ref name="openzeppelinforum-4119">[https://forum.openzeppelin.com/t/security-advisory-initialize-uups-implementation-contracts/15301 Security advisory: Initialize UUPS implementation contracts - Announcements - OpenZeppelin Community] (Dec 4, 2021)</ref>

	[https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-5vp3-v4hc-gx76 UUPSUpgradeable vulnerability in OpenZeppelin Contracts · Advisory · OpenZeppelin/openzeppelin-contracts · GitHub] (Dec 3)		<ref name="openzeppelingithub-4120">[https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-5vp3-v4hc-gx76 UUPSUpgradeable vulnerability in OpenZeppelin Contracts · Advisory · OpenZeppelin/openzeppelin-contracts · GitHub] (Dec 4, 2021)</ref>

	[https://forum.openzeppelin.com/t/uupsupgradeable-vulnerability-post-mortem/15680 UUPSUpgradeable Vulnerability Post-mortem - Announcements - OpenZeppelin Community] (Dec 3)		<ref name="openzeppelinforum-4121">[https://forum.openzeppelin.com/t/uupsupgradeable-vulnerability-post-mortem/15680 UUPSUpgradeable Vulnerability Post-mortem - Announcements - OpenZeppelin Community] (Dec 4, 2021)</ref>

	[https://geeksg.medium.com/my-journey-to-disclosing-a-vulnerability-that-can-lock-up-millions-in-ethereum-dcb5754ad9bc My Journey To Disclosing A Vulnerability That Can Lock Up Millions In Ethereum] (Dec 3)		<ref name="geeksgmedium-4122">[https://geeksg.medium.com/my-journey-to-disclosing-a-vulnerability-that-can-lock-up-millions-in-ethereum-dcb5754ad9bc My Journey To Disclosing A Vulnerability That Can Lock Up Millions In Ethereum] (Dec 4, 2021)</ref>

	[https://www.iosiro.com/blog/openzeppelin-uups-proxy-vulnerability-disclosure Perma-brick UUPS proxies with this one trick (devs hate this!) \| iosiro] (Dec 3)		<ref name="iosiro-4123">[https://www.iosiro.com/blog/openzeppelin-uups-proxy-vulnerability-disclosure Perma-brick UUPS proxies with this one trick (devs hate this!) \| iosiro] (Dec 4, 2021)</ref>

	[https://github.com/yehjxraymond/exploding-kitten GitHub - yehjxraymond/exploding-kitten] (Dec 3)		<ref name="yehjxraymondgithub-4124">[https://github.com/yehjxraymond/exploding-kitten GitHub - yehjxraymond/exploding-kitten] (Dec 4, 2021)</ref></references>